mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 69071: Narrowed interface of `ReadOnlyHandler` members.
Date Wed, 12 Dec 2018 20:47:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69071/
-----------------------------------------------------------

(Updated Dec. 12, 2018, 8:47 p.m.)


Review request for mesos, Alexander Rukletsov and Joseph Wu.


Changes
-------

Rebased onto latest master again.


Repository: mesos


Description (updated)
-------

Previously, the members of ReadOnlyHandler would take a full Request as parameter, making
it hard for clients to reason about which parts of the request are used internally, and even
harder to guarantee that behaviour into the future.

This commit changes the interface so only the query parameters get passed.


Diffs (updated)
-----

  src/master/http.cpp 68ee2a6dcffbc772afec6e797b1af8da48f61937 
  src/master/master.hpp c7becfa615964674dcf1ebd9424aa5818a0fdb85 
  src/master/readonly_handler.cpp 8895374499dc6baa2c4d8a8dd86fddac4e39be29 


Diff: https://reviews.apache.org/r/69071/diff/3/

Changes: https://reviews.apache.org/r/69071/diff/2-3/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message