mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69398: Added validation for framework IDs.
Date Tue, 11 Dec 2018 13:48:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69398/
-----------------------------------------------------------

(Updated Dec. 11, 2018, 2:48 p.m.)


Review request for mesos, Benjamin Mahler and Meng Zhu.


Changes
-------

Addressed Ben's comments.


Summary (updated)
-----------------

Added validation for framework IDs.


Bugs: MESOS-9469
    https://issues.apache.org/jira/browse/MESOS-9469


Repository: mesos


Description (updated)
-------

During scheduler subscription we currently cannot distinguish
self-assigned from master-assigned framework IDs, so we might allow
frameworks to subscribe even if the used framework ID was never assigned
by any master, see MESOS-1719.

This patch adds some validation of used framework IDs so that they can
e.g., savely be used in agents when persisting information.

We also clarify the API to call out that self-assigned framework IDs are
not explicitly supported.


Diffs (updated)
-----

  include/mesos/mesos.proto ef4d785d0bf7b202b4093bad6a478f84c25261f3 
  include/mesos/v1/mesos.proto 4e8f7a1bb1c47761f0407d2f4094aa24ce8c3fef 
  src/master/validation.hpp 9af903970795a5c8c479d1984a580e41d91f6c91 
  src/master/validation.cpp 5fccc9f4fa6a81c08c5013b06c7b7795897a13a5 
  src/tests/master_validation_tests.cpp 3aa7b2a2dcaf054ad2a67c52462493c97b7178c4 


Diff: https://reviews.apache.org/r/69398/diff/2/

Changes: https://reviews.apache.org/r/69398/diff/1-2/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message