mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 69474: Added tests for agent/executor heartbeating.
Date Mon, 10 Dec 2018 20:09:34 GMT


> On Dec. 10, 2018, 8:33 a.m., Benno Evers wrote:
> > src/tests/executor_http_api_tests.cpp
> > Lines 1232 (patched)
> > <https://reviews.apache.org/r/69474/diff/5/?file=2112655#file2112655line1232>
> >
> >     Let's please fix this `TODO` before committing.

I left this TODO because none of the executors have headers, outside of the public header
defining the executor driver interfaces.  There is a good deal of cleanup we could do by defining
headers for the executor driver, v0_v1 shim, command executor, and default executor.  There
are constants to pull out, environment variable checks we could translate into `Flags`, classes
which could be put in headers, etc.

But it wouldn't necessarily make sense to make these cleanups in this chain (or one at a time).


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69474/#review211143
-----------------------------------------------------------


On Dec. 7, 2018, 2:18 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69474/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2018, 2:18 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-7564
>     https://issues.apache.org/jira/browse/MESOS-7564
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds two separate tests which check if the Agent sends heartbeats
> to HTTP executors, and if the HTTP executor driver sends heartbeats
> to the agent.
> 
> 
> Diffs
> -----
> 
>   src/examples/long_lived_executor.cpp b87a8069892b3886329581e86ed15072dd785b3d 
>   src/examples/test_http_executor.cpp e5f7cbb3b4e35663717f2a74550f8378bfafb0f9 
>   src/tests/executor_http_api_tests.cpp a635e1a3c228b52f47ba81a67753ea49ce092143 
>   src/tests/mesos.hpp b57bbd40051fed0829453c56b90f5660354f4334 
> 
> 
> Diff: https://reviews.apache.org/r/69474/diff/5/
> 
> 
> Testing
> -------
> 
> ```
> cmake --build . --target check
> src/mesos-tests --gtest_filter="*Heartbeat*" --verbose --gtest_repeat=-1 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message