mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 69344: Added volume gid manager to Mesos agent.
Date Wed, 05 Dec 2018 19:35:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69344/#review211051
-----------------------------------------------------------




src/slave/volume_gid_manager/volume_gid_manager.cpp
Lines 58 (patched)
<https://reviews.apache.org/r/69344/#comment295910>

    `return ErrnoError("Failed to open '" + path + "'");`



src/slave/volume_gid_manager/volume_gid_manager.cpp
Lines 62 (patched)
<https://reviews.apache.org/r/69344/#comment295907>

    `fts_read` is not thread safe (`MT-Unsafe`). However, we have couple of places in `stout`
where we call `fts_read` as well.



src/slave/volume_gid_manager/volume_gid_manager.cpp
Lines 77 (patched)
<https://reviews.apache.org/r/69344/#comment295908>

    It might be unsafe to access `node`'s entries, since most likely memory for `node` was
freed by `fts_close(tree)`.



src/slave/volume_gid_manager/volume_gid_manager.cpp
Lines 122 (patched)
<https://reviews.apache.org/r/69344/#comment295909>

    `return ErrnoError("Failed to stop traversing file system");`



src/slave/volume_gid_manager/volume_gid_manager.cpp
Lines 154 (patched)
<https://reviews.apache.org/r/69344/#comment295911>

    Is it possible to add range values to the error message?



src/slave/volume_gid_manager/volume_gid_manager.cpp
Lines 275 (patched)
<https://reviews.apache.org/r/69344/#comment295912>

    Should we add `parse.error()` to the error message?


- Andrei Budnik


On Dec. 4, 2018, 2:42 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69344/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2018, 2:42 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, and Jie
Yu.
> 
> 
> Bugs: MESOS-8810
>     https://issues.apache.org/jira/browse/MESOS-8810
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added volume gid manager to Mesos agent.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt bde070445b644e15d46c390d1c983caabaa1fec8 
>   src/Makefile.am 8da1a05b618f17542fec9b5057484a9bae57658a 
>   src/slave/volume_gid_manager/volume_gid_manager.hpp PRE-CREATION 
>   src/slave/volume_gid_manager/volume_gid_manager.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69344/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message