mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 69463: Added HEARTBEAT events and calls for the executor HTTP API.
Date Tue, 04 Dec 2018 22:29:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69463/#review211027
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/executor/executor.proto
Lines 70 (patched)
<https://reviews.apache.org/r/69463/#comment295877>

    s/Recieved/Received/


- Greg Mann


On Nov. 27, 2018, 10:11 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69463/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2018, 10:11 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-7564
>     https://issues.apache.org/jira/browse/MESOS-7564
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These new messages are meant to be backwards compatible, in that
> they won't cause crashes when new executors send heartbeats to old
> agents, or new agents send heartbeats to old executors.  All recipients
> of these heartbeats are currently expected to ignore them, as their
> only purpose is to keep certain connections from being marked "stale"
> by network intermediaries.
> 
> 
> Diffs
> -----
> 
>   include/mesos/executor/executor.proto 1b5fa5dab6944a8649fb98447eeec7105495b879 
>   include/mesos/v1/executor/executor.proto b2ef325cf6a72137854355d541889c7c6ae7c230 
> 
> 
> Diff: https://reviews.apache.org/r/69463/diff/1/
> 
> 
> Testing
> -------
> 
> cmake --build . --target mesos-protobufs
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message