mesos-reviews mailing list archives: November 2018

Site index · List index
Message list1 · 2 · 3 · 4 · 5 · Next »Thread · Author · Date
Re: Review Request 69116: Added 'popen_tty' to test util functions for the new CLI.
Mesos Reviewbot Windows   Re: Review Request 69116: Added 'popen_tty' to test util functions for the new CLI. Thu, 01 Nov, 00:17
Mesos Reviewbot   Re: Review Request 69116: Added 'popen_tty' to test util functions for the new CLI. Thu, 01 Nov, 00:45
Kevin Klues   Re: Review Request 69116: Added 'popen_tty()' to test util functions for the new CLI. Fri, 02 Nov, 23:16
Mesos Reviewbot Windows   Re: Review Request 69116: Added 'popen_tty()' to test util functions for the new CLI. Fri, 02 Nov, 23:44
Chun-Hung Hsiao Review Request 69224: Fixed a test flake in `HealthCheckTest.HealthyTaskNonShell`. Thu, 01 Nov, 03:15
Mesos Reviewbot Windows   Re: Review Request 69224: Fixed a test flake in `HealthCheckTest.HealthyTaskNonShell`. Thu, 01 Nov, 04:45
Alexander Rukletsov   Re: Review Request 69224: Fixed a test flake in `HealthCheckTest.HealthyTaskNonShell`. Thu, 01 Nov, 06:38
Till Toenshoff via Review Board   Re: Review Request 69224: Fixed a test flake in `HealthCheckTest.HealthyTaskNonShell`. Thu, 01 Nov, 16:17
James Peach Review Request 69233: Fixed a GetContainers crash when using XFS disk isolation. Thu, 01 Nov, 20:33
Jiang Yan Xu   Re: Review Request 69233: Fixed a GetContainers crash when using XFS disk isolation. Thu, 01 Nov, 20:55
Mesos Reviewbot Windows   Re: Review Request 69233: Fixed a GetContainers crash when using XFS disk isolation. Thu, 01 Nov, 22:07
Mesos Reviewbot   Re: Review Request 69233: Fixed a GetContainers crash when using XFS disk isolation. Fri, 02 Nov, 01:31
Qian Zhang Review Request 69234: Made debug container runs as its parent container's user by default. Thu, 01 Nov, 21:25
Gilbert Song   Re: Review Request 69234: Made debug container runs as its parent container's user by default. Fri, 02 Nov, 21:38
Qian Zhang   Re: Review Request 69234: Made nested container runs as its parent container's user by default. Mon, 05 Nov, 08:02
Gilbert Song     Re: Review Request 69234: Made nested container runs as its parent container's user by default. Thu, 08 Nov, 06:43
Qian Zhang Review Request 69235: Added a test `ROOT_UNPRIVILEGED_USER_DefaultExecutorCommandHealthCheck`. Thu, 01 Nov, 21:28
Gilbert Song   Re: Review Request 69235: Added a test `ROOT_UNPRIVILEGED_USER_DefaultExecutorCommandHealthCheck`. Thu, 08 Nov, 06:43
Qian Zhang Review Request 69236: Fixed a coding error that a test waited on a wrong task status update. Thu, 01 Nov, 21:29
Gilbert Song   Re: Review Request 69236: Fixed a coding error that a test waited on a wrong task status update. Thu, 01 Nov, 21:41
Mesos Reviewbot Windows   Re: Review Request 69236: Fixed a coding error that a test waited on a wrong task status update. Thu, 01 Nov, 23:04
Mesos Reviewbot   Re: Review Request 69236: Fixed a coding error that a test waited on a wrong task status update. Fri, 02 Nov, 03:43
Re: Review Request 69115: Added test for interactive 'task exec'.
Kevin Klues   Re: Review Request 69115: Added test for interactive 'task exec'. Thu, 01 Nov, 22:26
Kevin Klues   Re: Review Request 69115: Added test for interactive 'task exec'. Thu, 01 Nov, 22:28
Kevin Klues   Re: Review Request 69115: Added test for interactive 'task exec'. Thu, 01 Nov, 22:28
Armand Grillet Review Request 69237: Simplified 'test_exec' in new CLI to better manage newlines. Thu, 01 Nov, 22:28
Mesos Reviewbot Windows   Re: Review Request 69237: Simplified 'test_exec' in new CLI to better manage newlines. Fri, 02 Nov, 00:30
Kevin Klues   Re: Review Request 69237: Simplified newline handling in 'test_exec()' test for new CLI. Fri, 02 Nov, 23:39
Mesos Reviewbot Windows   Re: Review Request 69237: Simplified newline handling in 'test_exec()' test for new CLI. Fri, 02 Nov, 23:45
Re: Review Request 68706: Added master failover reregistration progress metrics.
Jiang Yan Xu   Re: Review Request 68706: Added master failover reregistration progress metrics. Fri, 02 Nov, 08:19
Jiang Yan Xu   Re: Review Request 68706: Added master failover reregistration progress metrics. Fri, 02 Nov, 08:24
Benjamin Bannier Review Request 69242: Saved some disk space in mesos-tidy Docker image. Fri, 02 Nov, 20:50
Mesos Reviewbot Windows   Re: Review Request 69242: Saved some disk space in mesos-tidy Docker image. Fri, 02 Nov, 22:16
Chun-Hung Hsiao   Re: Review Request 69242: Saved some disk space in mesos-tidy Docker image. Fri, 02 Nov, 22:26
Mesos Reviewbot   Re: Review Request 69242: Saved some disk space in mesos-tidy Docker image. Sat, 03 Nov, 01:54
Benjamin Bannier Review Request 69243: Used a `switch` statement to match enum values. Fri, 02 Nov, 20:51
Mesos Reviewbot Windows   Re: Review Request 69243: Used a `switch` statement to match enum values. Fri, 02 Nov, 22:19
Chun-Hung Hsiao   Re: Review Request 69243: Used a `switch` statement to match enum values. Fri, 02 Nov, 22:53
Mesos Reviewbot   Re: Review Request 69243: Used a `switch` statement to match enum values. Sat, 03 Nov, 04:23
Re: Review Request 69092: Added default arguments to `FrameworkProfile` in allocator benchmark.
Benjamin Mahler   Re: Review Request 69092: Added default arguments to `FrameworkProfile` in allocator benchmark. Fri, 02 Nov, 21:57
Benjamin Mahler   Re: Review Request 69092: Added default arguments to `FrameworkProfile` in allocator benchmark. Fri, 02 Nov, 21:58
Re: Review Request 69093: Removed `used` argument in `AgentProfile` in the allocator benchmark.
Benjamin Mahler   Re: Review Request 69093: Removed `used` argument in `AgentProfile` in the allocator benchmark. Fri, 02 Nov, 21:59
Benjamin Mahler   Re: Review Request 69093: Removed `used` argument in `AgentProfile` in the allocator benchmark. Fri, 02 Nov, 21:59
Re: Review Request 69096: Moved a few allocator test helpers to `tests/allocator.hpp`.
Benjamin Mahler   Re: Review Request 69096: Moved a few allocator test helpers to `tests/allocator.hpp`. Fri, 02 Nov, 22:02
Re: Review Request 69097: Added an allocator benchmark for quota performance.
Benjamin Mahler   Re: Review Request 69097: Added an allocator benchmark for quota performance. Fri, 02 Nov, 22:22
Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.
Chun-Hung Hsiao   Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations. Fri, 02 Nov, 22:22
Chun-Hung Hsiao     Re: Review Request 69036: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations. Thu, 15 Nov, 23:52
Benjamin Bannier       Re: Review Request 69036: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations. Tue, 20 Nov, 17:02
Re: Review Request 69098: Added a benchmark to compare quota and nonquota allocation performance.
Benjamin Mahler   Re: Review Request 69098: Added a benchmark to compare quota and nonquota allocation performance. Fri, 02 Nov, 22:23
Re: Review Request 69207: Moved 'updated_tasks()' to new CLI tests base.
Mesos Reviewbot Windows   Re: Review Request 69207: Moved 'updated_tasks()' to new CLI tests base. Fri, 02 Nov, 22:23
Kevin Klues   Re: Review Request 69207: Moved 'updated_tasks()' to new CLI tests base. Fri, 02 Nov, 23:21
Kevin Klues   Re: Review Request 69207: Moved 'updated_tasks()' to new CLI tests base. Fri, 02 Nov, 23:36
Re: Review Request 69161: Renamed a function argument to not reuse member name.
Chun-Hung Hsiao   Re: Review Request 69161: Renamed a function argument to not reuse member name. Fri, 02 Nov, 23:35
Benjamin Bannier     Re: Review Request 69161: Renamed a function argument to not reuse member name. Mon, 12 Nov, 08:57
Benjamin Bannier   Re: Review Request 69161: Renamed a function argument to not reuse member name. Mon, 12 Nov, 08:57
Re: Review Request 69206: Updated new CLI commands for new CLI to return proper exit status.
Kevin Klues   Re: Review Request 69206: Updated new CLI commands for new CLI to return proper exit status. Fri, 02 Nov, 23:45
Re: Review Request 69208: Updated new CLI task attach/exec exit strategy.
Mesos Reviewbot Windows   Re: Review Request 69208: Updated new CLI task attach/exec exit strategy. Fri, 02 Nov, 23:51
Kevin Klues   Re: Review Request 69208: Updated new CLI task attach/exec exit strategy. Sat, 03 Nov, 00:04
Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`.
Mesos Reviewbot Windows   Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`. Sat, 03 Nov, 01:22
Mesos Reviewbot Windows   Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`. Wed, 07 Nov, 01:44
Mesos Reviewbot Windows   Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`. Thu, 08 Nov, 19:49
Mesos Reviewbot   Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`. Thu, 08 Nov, 20:23
Mesos Reviewbot Windows   Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`. Fri, 09 Nov, 02:28
Mesos Reviewbot   Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`. Fri, 09 Nov, 06:15
James Peach   Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`. Sat, 17 Nov, 00:50
Mesos Reviewbot Windows     Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`. Sat, 17 Nov, 02:18
Mesos Reviewbot Windows     Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`. Tue, 27 Nov, 02:26
Re: Review Request 69086: Moved container root construction to the isolators.
James Peach   Re: Review Request 69086: Moved container root construction to the isolators. Sat, 03 Nov, 18:49
James Peach     Re: Review Request 69086: Moved container root construction to the isolators. Fri, 09 Nov, 00:53
Jie Yu   Re: Review Request 69086: Moved container root construction to the isolators. Mon, 05 Nov, 05:14
James Peach     Re: Review Request 69086: Moved container root construction to the isolators. Tue, 06 Nov, 06:07
James Peach     Re: Review Request 69086: Moved container root construction to the isolators. Fri, 09 Nov, 22:48
James Peach   Re: Review Request 69086: Moved container root construction to the isolators. Fri, 09 Nov, 00:53
James Peach     Re: Review Request 69086: Moved container root construction to the isolators. Sat, 17 Nov, 00:49
James Peach       Re: Review Request 69086: Moved the container root construction to the isolators. Tue, 27 Nov, 00:49
GitBox [GitHub] mlowicki opened a new pull request #318: Add info about Rhythm framework Sat, 03 Nov, 22:39
GitBox [GitHub] vinodkone closed pull request #318: Add info about Rhythm framework Sun, 04 Nov, 04:28
Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.
Alexander Rukletsov   Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test. Sun, 04 Nov, 04:31
Mesos Reviewbot Windows     Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test. Sun, 04 Nov, 06:07
Mesos Reviewbot     Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test. Sun, 04 Nov, 07:04
Benno Evers     Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test. Tue, 06 Nov, 12:19
Alexander Rukletsov       Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test. Sun, 18 Nov, 04:49
Alexander Rukletsov       Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test. Sun, 18 Nov, 20:13
Benno Evers       Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test. Mon, 19 Nov, 12:22
Alexander Rukletsov     Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test. Sun, 18 Nov, 20:10
Mesos Reviewbot Windows       Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test. Sun, 18 Nov, 21:46
Mesos Reviewbot       Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test. Mon, 19 Nov, 20:41
Armand Grillet Review Request 69255: Updated PyInstaller requirement for new CLI to support Python 3.7. Mon, 05 Nov, 18:13
Mesos Reviewbot Windows   Re: Review Request 69255: Updated PyInstaller requirement for new CLI to support Python 3.7. Mon, 05 Nov, 19:52
Benjamin Bannier   Re: Review Request 69255: Updated PyInstaller requirement for new CLI to support Python 3.7. Mon, 05 Nov, 20:48
Armand Grillet     Re: Review Request 69255: Updated PyInstaller requirement for new CLI to support Python 3.7. Mon, 05 Nov, 22:22
Mesos Reviewbot Windows   Re: Review Request 69255: Updated PyInstaller requirement for new CLI to support Python 3.7. Fri, 16 Nov, 23:07
Kevin Klues   Re: Review Request 69255: Updated PyInstaller requirement for new CLI to support Python 3.7. Mon, 19 Nov, 16:31
Re: Review Request 67955: Added some new generic flag parsers.
Benjamin Mahler   Re: Review Request 67955: Added some new generic flag parsers. Tue, 06 Nov, 05:36
Re: Review Request 67956: Removed some generic flag parsers that are now in stout.
Benjamin Mahler   Re: Review Request 67956: Removed some generic flag parsers that are now in stout. Tue, 06 Nov, 05:36
Re: Review Request 67957: Refactored TemporaryDirectoryTest to be a mixin.
Benjamin Mahler   Re: Review Request 67957: Refactored TemporaryDirectoryTest to be a mixin. Tue, 06 Nov, 05:49
Re: Review Request 67958: Added LibprocessTest for easily configuring the library for a test.
Benjamin Mahler   Re: Review Request 67958: Added LibprocessTest for easily configuring the library for a test. Tue, 06 Nov, 05:58
Benjamin Bannier     Re: Review Request 67958: Added LibprocessTest for easily configuring the library for a test. Tue, 06 Nov, 06:07
Benjamin Mahler     Re: Review Request 67958: Added LibprocessTest for easily configuring the library for a test. Tue, 06 Nov, 15:41
Re: Review Request 67959: Added support for instrumenting processes.
Benjamin Mahler   Re: Review Request 67959: Added support for instrumenting processes. Tue, 06 Nov, 06:13
Joseph Wu Review Request 69267: Fixed flaky SchedulerTest.MasterFailover. Wed, 07 Nov, 01:26
Mesos Reviewbot Windows   Re: Review Request 69267: Fixed flaky SchedulerTest.MasterFailover. Wed, 07 Nov, 03:17
Alexander Rukletsov   Re: Review Request 69267: Fixed flaky SchedulerTest.MasterFailover. Thu, 08 Nov, 01:05
Mesos Reviewbot   Re: Review Request 69267: Fixed flaky SchedulerTest.MasterFailover. Thu, 08 Nov, 10:10
Re: Review Request 67022: Refreshed checkpointed SlaveInfo if `--reconfiguration_policy==any`.
Benno Evers   Re: Review Request 67022: Refreshed checkpointed SlaveInfo if `--reconfiguration_policy==any`. Wed, 07 Nov, 14:25
Mesos Reviewbot   Re: Review Request 67022: Refreshed checkpointed SlaveInfo if `--reconfiguration_policy==any`. Wed, 07 Nov, 21:11
Benno Evers Review Request 69272: Clarified some comments about the usage of offer filters. Wed, 07 Nov, 18:40
Joseph Wu   Re: Review Request 69272: Clarified some comments about the usage of offer filters. Wed, 07 Nov, 21:33
Benno Evers Review Request 69273: Fixed flaky agent reconfiguration test. Wed, 07 Nov, 18:40
Mesos Reviewbot Windows   Re: Review Request 69273: Fixed flaky agent reconfiguration test. Wed, 07 Nov, 20:12
Joseph Wu   Re: Review Request 69273: Fixed flaky agent reconfiguration test. Wed, 07 Nov, 21:44
Benno Evers     Re: Review Request 69273: Fixed flaky agent reconfiguration test. Mon, 12 Nov, 14:34
Joseph Wu     Re: Review Request 69273: Fixed flaky agent reconfiguration test. Wed, 14 Nov, 00:07
Benno Evers   Re: Review Request 69273: Fixed flaky agent reconfiguration test. Mon, 12 Nov, 14:33
Mesos Reviewbot Windows     Re: Review Request 69273: Fixed flaky agent reconfiguration test. Mon, 12 Nov, 16:14
Benno Evers     Re: Review Request 69273: Fixed flaky agent reconfiguration test. Wed, 14 Nov, 15:23
Benno Evers       Re: Review Request 69273: Fixed flaky agent reconfiguration test. Wed, 14 Nov, 15:26
Mesos Reviewbot Windows       Re: Review Request 69273: Fixed flaky agent reconfiguration test. Wed, 14 Nov, 17:41
Joseph Wu       Re: Review Request 69273: Fixed flaky agent reconfiguration test. Wed, 14 Nov, 20:23
Benjamin Bannier Review Request 69274: Reduced default oversubscription in parallel test runner. Wed, 07 Nov, 20:30
Benjamin Mahler   Re: Review Request 69274: Reduced default oversubscription in parallel test runner. Wed, 07 Nov, 21:13
Armand Grillet   Re: Review Request 69274: Reduced default oversubscription in parallel test runner. Wed, 07 Nov, 21:16
Mesos Reviewbot   Re: Review Request 69274: Reduced default oversubscription in parallel test runner. Wed, 07 Nov, 23:40
Mesos Reviewbot Windows   Re: Review Request 69274: Reduced default oversubscription in parallel test runner. Thu, 08 Nov, 00:49
Benjamin Bannier Review Request 69275: Added environment sanity check to parallel test runner. Wed, 07 Nov, 20:30
Benjamin Mahler   Re: Review Request 69275: Added environment sanity check to parallel test runner. Wed, 07 Nov, 21:14
Armand Grillet   Re: Review Request 69275: Added environment sanity check to parallel test runner. Wed, 07 Nov, 21:15
Benjamin Bannier   Re: Review Request 69275: Added environment sanity check to parallel test runner. Wed, 07 Nov, 21:41
Armand Grillet     Re: Review Request 69275: Added environment sanity check to parallel test runner. Wed, 07 Nov, 21:42
Mesos Reviewbot Windows     Re: Review Request 69275: Added environment sanity check to parallel test runner. Wed, 07 Nov, 21:56
Benjamin Mahler Review Request 69276: Fixed flakiness in `FsTest.Used`. Wed, 07 Nov, 21:16
James Peach   Re: Review Request 69276: Fixed flakiness in `FsTest.Used`. Wed, 07 Nov, 21:24
Joseph Wu   Re: Review Request 69276: Fixed flakiness in `FsTest.Used`. Wed, 07 Nov, 21:27
Benjamin Bannier Review Request 69278: Added hierchical allocator benchmarks to the cmake build. Wed, 07 Nov, 21:17
Joseph Wu   Re: Review Request 69278: Added hierchical allocator benchmarks to the cmake build. Wed, 07 Nov, 21:29
Mesos Reviewbot Windows   Re: Review Request 69278: Added hierchical allocator benchmarks to the cmake build. Thu, 08 Nov, 00:28
Message list1 · 2 · 3 · 4 · 5 · Next »Thread · Author · Date
Box list
Aug 2019353
Jul 2019707
Jun 2019621
May 2019472
Apr 2019702
Mar 2019955
Feb 2019758
Jan 2019749
Dec 2018455
Nov 2018598
Oct 2018832
Sep 2018704
Aug 20181218
Jul 20181040
Jun 20181026
May 20181520
Apr 20181445
Mar 20181350
Feb 20181396
Jan 20181470
Dec 20171464
Nov 20171769
Oct 20171445
Sep 20171054
Aug 20171341
Jul 20171295
Jun 20171475
May 20171547
Apr 20171266
Mar 20172102
Feb 20171631
Jan 20171655
Dec 20161774
Nov 20162300
Oct 20162196
Sep 20162748
Aug 20162311
Jul 20163001
Jun 20163216
May 20162928
Apr 20163332
Mar 20164025
Feb 20162997
Jan 20163700
Dec 20152431
Nov 20152744
Oct 20152284
Sep 20152621
Aug 20152300
Jul 20152051
Jun 20152449
May 20151444
Apr 2015338