mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 69472: Moved heartbeating helper out of master.
Date Wed, 28 Nov 2018 23:56:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69472/
-----------------------------------------------------------

Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.


Bugs: MESOS-7564
    https://issues.apache.org/jira/browse/MESOS-7564


Repository: mesos


Description
-------

This helper for sending heartbeats is generic enough to be used outside
of the master for other actors, like the agent, which may
need to send heartbeats of their own.

The moved heartbeater is tweaked a little in order to remove the
dependency on the `internal::master::HttpConnection` object.


Diffs
-----

  src/common/heartbeater.hpp PRE-CREATION 
  src/master/framework.cpp 36eda9f287bef28608024e0036db1f955a1b393c 
  src/master/master.hpp 3b3c1a4e61de9503c8d038dd3bee623ded5914c9 


Diff: https://reviews.apache.org/r/69472/diff/1/


Testing
-------

make

The original plan was to use the same helper for the executor too, but of the Master, Framework,
and Agent heartbeats, only the executor lacks a streaming connection.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message