mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 69157: Fixed handling for offer operation updates.
Date Tue, 27 Nov 2018 23:40:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69157/#review210897
-----------------------------------------------------------




src/slave/slave.cpp
Lines 8016-8037 (original), 8016-8037 (patched)
<https://reviews.apache.org/r/69157/#comment295741>

    Hmm I think you may have mis-read Chun-Hung's comment here - I think he was suggesting
that we use `operation->latest_status().state()` in both places?



src/slave/slave.cpp
Line 8037 (original), 8037 (patched)
<https://reviews.apache.org/r/69157/#comment295715>

    Hmm it looks like Chun-Hung's comment was resolved, but this line still uses `update`
instead of `operation`?


- Greg Mann


On Nov. 27, 2018, 5:59 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69157/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2018, 5:59 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8403
>     https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The handling of offer operation updates introduced in `c946615ec6d`
> made use of an update's `latest_status` without making sure that any
> value was set. This could lead to situation where an uninitialized
> enum value was switched on which would have caused a fatal error at
> runtime.
> 
> This patch replaces uses of `latest_status` with `state` which does
> contain the information we care about. We also adjust the error
> logging so we log the value that lead to the error, not some other
> value.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 858b78620e1ef33f3587d0bd95a684917aaf5bbb 
> 
> 
> Diff: https://reviews.apache.org/r/69157/diff/5/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message