mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <>
Subject Re: Review Request 69157: Fixed handling for offer operation updates.
Date Tue, 27 Nov 2018 17:59:56 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 27, 2018, 6:59 p.m.)

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.

Bugs: MESOS-8403

Repository: mesos


The handling of offer operation updates introduced in `c946615ec6d`
made use of an update's `latest_status` without making sure that any
value was set. This could lead to situation where an uninitialized
enum value was switched on which would have caused a fatal error at

This patch replaces uses of `latest_status` with `state` which does
contain the information we care about. We also adjust the error
logging so we log the value that lead to the error, not some other

Diffs (updated)

  src/slave/slave.cpp 858b78620e1ef33f3587d0bd95a684917aaf5bbb 




`make check`


Benjamin Bannier

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message