mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
Date Mon, 26 Nov 2018 13:51:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69395/
-----------------------------------------------------------

(Updated Nov. 26, 2018, 2:51 p.m.)


Review request for mesos and Kevin Klues.


Changes
-------

Rebased.


Bugs: MESOS-9399
    https://issues.apache.org/jira/browse/MESOS-9399


Repository: mesos


Description
-------

With this option, the command can show all the tasks that have ever been
run. This makes the command's behavior closer to the one of 'docker ps'.


Diffs (updated)
-----

  src/python/cli_new/lib/cli/plugins/task/main.py 0ce21b365d64c5c331ce7f1a5937258960e15b6f

  src/python/cli_new/lib/cli/tests/task.py eb01bf5cae095a067572f534a13f4ec542101ca5 


Diff: https://reviews.apache.org/r/69395/diff/4/

Changes: https://reviews.apache.org/r/69395/diff/3-4/


Testing
-------

```
(mesos-cli) ?  cli_new (MESOS-9399) ? mesos-cli-tests
Running the Mesos CLI unit tests

TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok

TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok

TestTaskPlugin
test_exec (cli.tests.task.TestTaskPlugin) ... ok
test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
test_list (cli.tests.task.TestTaskPlugin) ... ok
test_list_all (cli.tests.task.TestTaskPlugin) ... ok

----------------------------------------------------------------------
Ran 8 tests in 20.889s

OK
```


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message