mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 69421: Exposed private data members for testing.
Date Mon, 26 Nov 2018 12:23:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69421/#review210857
-----------------------------------------------------------




src/master/master.hpp
Lines 1387 (patched)
<https://reviews.apache.org/r/69421/#comment295650>

    I've implemented the "cleaner" approach of pulling out `ReadOnlyHandler` into a separate
header in https://reviews.apache.org/r/69445/
    
    The cleaner structuring comes at the cost of asymmetry between `ReadOnlyHandler` and the
other inner handler classes, and a raw pointer member in a non-inner class, so I opted for
this version instead.
    
    It's not a strong preference though, so I'd be happy to merge the linked alternative into
this review as well.


- Benno Evers


On Nov. 22, 2018, 1:21 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69421/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2018, 1:21 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For the unit tests introduced in the subsequent
> commit, access to the underlying master object
> of `cluster::Master` and to the definition of the
> class `Master::ReadOnlyHandler` are required.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 3b3c1a4e61de9503c8d038dd3bee623ded5914c9 
>   src/tests/cluster.hpp ad2b80e658d2f8afcefe9969d62cd33f0c475ce9 
> 
> 
> Diff: https://reviews.apache.org/r/69421/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message