mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'.
Date Sun, 25 Nov 2018 11:08:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69426/
-----------------------------------------------------------

(Updated Nov. 25, 2018, 12:08 p.m.)


Review request for mesos and Kevin Klues.


Changes
-------

Fixed issues.


Bugs: MESOS-9399
    https://issues.apache.org/jira/browse/MESOS-9399


Repository: mesos


Description
-------

Replaces 'running_tasks(master)', a function that was not generic nor
explicit, by 'wait_for_task(master, name, state, delay)'. This helper
function waits a 'delay' for a task with a given 'name' to be in a
certain 'state'.

All uses of 'running_tasks' have been replaced by the new function.


Diffs (updated)
-----

  src/python/cli_new/lib/cli/tests/base.py c28e2a65b5c1b881c2f4eb09baf9806338f26e40 
  src/python/cli_new/lib/cli/tests/task.py 1b48c0a4729043c874330552074b05368e38b715 


Diff: https://reviews.apache.org/r/69426/diff/2/

Changes: https://reviews.apache.org/r/69426/diff/1-2/


Testing
-------

```
(mesos-cli) ?  cli_new (MESOS-9399) ? mesos-cli-tests
Running the Mesos CLI unit tests

TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok

TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok

TestTaskPlugin
test_exec (cli.tests.task.TestTaskPlugin) ... ok
test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
test_list (cli.tests.task.TestTaskPlugin) ... ok

----------------------------------------------------------------------
Ran 7 tests in 19.319s

OK
```


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message