mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Review Request 69436: Fixed flaky check in cluster::Slave destructor.
Date Thu, 22 Nov 2018 19:43:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69436/
-----------------------------------------------------------

Review request for mesos, Andrei Budnik and Joseph Wu.


Bugs: MESOS-9272
    https://issues.apache.org/jira/browse/MESOS-9272


Repository: mesos


Description
-------

The destructor of `cluster::Slave` contained an assertion
that was not safe to assume in the presence of the
composing containerizer. This commit adds an additional
`Clock::settle()` to fix the issue.


Diffs
-----

  src/tests/cluster.cpp 2b351ca70d8e80008e49722aa7d46918b5ecd9b0 


Diff: https://reviews.apache.org/r/69436/diff/1/


Testing
-------

Ran `./src/mesos-tests --gtest_filter="SlaveTest.DefaultExecutorCommandInfo" --verbose --gtest_repeat=50000
--gtest_throw_on_failure` while simulatenously running `stress-ng --random 64` on the same
machine.

(before the change, `SlaveTest.DefaultExecutorCommandInfo` would fail roughly once every 15000
runs without `stress-ng` and roughly once every 300 runs with `stress-ng`)


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message