mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
Date Thu, 22 Nov 2018 17:30:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69395/#review210815
-----------------------------------------------------------



Bad patch!

Reviews applied: [69395, 69426, 69425, 69394, 69393]

Failed command: /usr/bin/python3 support/apply-reviews.py -n -r 69394

Error:
2018-11-22 17:30:19 URL:https://reviews.apache.org/r/69394/diff/raw/ [2592/2592] -> "69394.patch"
[1]
error: patch failed: src/python/cli_new/lib/cli/plugins/task/main.py:126
error: src/python/cli_new/lib/cli/plugins/task/main.py: patch does not apply
error: patch failed: src/python/cli_new/lib/cli/tests/task.py:186
error: src/python/cli_new/lib/cli/tests/task.py: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/23570/console

- Mesos Reviewbot


On Nov. 22, 2018, 11:36 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69395/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2018, 11:36 a.m.)
> 
> 
> Review request for Kevin Klues.
> 
> 
> Bugs: MESOS-9399
>     https://issues.apache.org/jira/browse/MESOS-9399
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> With this option, the command can show all the tasks that have ever been
> run. This makes the command's behavior closer to the one of 'docker ps'.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/lib/cli/plugins/task/main.py 0536ccb29551400ce59713017c86eb5e858aeb5f

>   src/python/cli_new/lib/cli/tests/task.py f033b4a7663279c8a7c49ed86b3acdda45ceb107 
> 
> 
> Diff: https://reviews.apache.org/r/69395/diff/2/
> 
> 
> Testing
> -------
> 
> ```
> (mesos-cli) ?  cli_new (MESOS-9399) ? mesos-cli-tests
> Running the Mesos CLI unit tests
> 
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
> 
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
> 
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> test_list_all (cli.tests.task.TestTaskPlugin) ... ok
> 
> ----------------------------------------------------------------------
> Ran 8 tests in 20.889s
> 
> OK
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message