mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Review Request 69422: WIP: Add new metric for cache hits.
Date Thu, 22 Nov 2018 01:22:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69422/
-----------------------------------------------------------

Review request for mesos and Joseph Wu.


Repository: mesos


Description
-------

The idea was to use this in unit tests as well as for
benchmarks to verify that caching actually happens.

However, it's currently not integrated into the unit test
because it's unclear what should happen in case the test
detects that no caching occurred.


Diffs
-----

  src/master/http.cpp 68ee2a6dcffbc772afec6e797b1af8da48f61937 
  src/master/metrics.hpp f6bb89da9394bfe469bc690ff2de66824e994098 
  src/master/metrics.cpp f69ed52c1c89912e7a5d26cb9409f5959b09111a 


Diff: https://reviews.apache.org/r/69422/diff/1/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message