mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 69411: Added new interface for constructing `cluster::Master`.
Date Thu, 22 Nov 2018 01:21:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69411/
-----------------------------------------------------------

(Updated Nov. 22, 2018, 1:21 a.m.)


Review request for mesos and Joseph Wu.


Changes
-------

Rebased onto latest master.


Repository: mesos


Description
-------

This review adds a new method `cluster::Master::create()` that
allows constructing masters while only specifying the non-standard
components required for the specific test, like this:

    auto master = cluster::Master::build()
      .withZookeeperUrl(url)
      .withAllocator(allocator);

This is sometimes better known as "fluent interface".


Diffs (updated)
-----

  src/tests/cluster.hpp ad2b80e658d2f8afcefe9969d62cd33f0c475ce9 
  src/tests/cluster.cpp 2b351ca70d8e80008e49722aa7d46918b5ecd9b0 


Diff: https://reviews.apache.org/r/69411/diff/2/

Changes: https://reviews.apache.org/r/69411/diff/1-2/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message