mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 69290: Added a new scheduler v1 call `unsuppress`.
Date Wed, 21 Nov 2018 23:59:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69290/
-----------------------------------------------------------

(Updated Nov. 21, 2018, 3:59 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Greg Mann.


Changes
-------

Updated the scheduler driver to accommodate the 200OK response.


Bugs: MESOS-9028
    https://issues.apache.org/jira/browse/MESOS-9028


Repository: mesos


Description (updated)
-------

`unsuppress` informs master to resume sending offers to
the framework without altering any existing filters.
Master will return 200 OK for the request after processing.

Also updated the scheduler library to support processing
the new call response.


Diffs (updated)
-----

  include/mesos/scheduler/scheduler.proto f6a780a7b75878b9e74402a28a25bb868f7ac36f 
  include/mesos/v1/scheduler/scheduler.proto fcfec5e417463103e98dd6917722b4fde41cac7c 
  src/master/http.cpp 68ee2a6dcffbc772afec6e797b1af8da48f61937 
  src/master/master.hpp 3b3c1a4e61de9503c8d038dd3bee623ded5914c9 
  src/master/master.cpp b4b02d8b4d7d6d1aabda1f97b9bf824419f76a9e 
  src/master/validation.cpp 5768ac8fe802f28855fbd7be135c711115532771 
  src/scheduler/scheduler.cpp cb24ba9c8e1d04b8c62bdf07b12758a61b3bf036 


Diff: https://reviews.apache.org/r/69290/diff/2/

Changes: https://reviews.apache.org/r/69290/diff/1-2/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message