mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 69398: Added validation for `FrameworkID`s.
Date Wed, 21 Nov 2018 18:52:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69398/#review210771
-----------------------------------------------------------


Ship it!




Ship It!

- Meng Zhu


On Nov. 19, 2018, 7:52 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69398/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2018, 7:52 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-8470
>     https://issues.apache.org/jira/browse/MESOS-8470
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We never explicitly supported `FrameworkID`s containing literal `/`.
> Moreover, since the introduction of hierarchical roles such
> `FrameworkID`s would cause fatal errors.
> 
> This patch adds validation for `FrameworkID`s so such IDs are
> rejected.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.hpp 9af903970795a5c8c479d1984a580e41d91f6c91 
>   src/master/validation.cpp 5768ac8fe802f28855fbd7be135c711115532771 
>   src/tests/master_validation_tests.cpp aa7c8f70c09459be32c6c415497e95fcdc218efd 
> 
> 
> Diff: https://reviews.apache.org/r/69398/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message