mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69357: Added profiles to storage pools in tests for `CREATE_DISK`.
Date Wed, 21 Nov 2018 02:36:25 GMT


> On Nov. 20, 2018, 3:47 p.m., Benjamin Bannier wrote:
> > src/tests/operation_reconciliation_tests.cpp
> > Lines 795-797 (original), 795-798 (patched)
> > <https://reviews.apache.org/r/69357/diff/2/?file=2108786#file2108786line795>
> >
> >     Nit: old indent was fine IMO.

Dropping this and created https://issues.apache.org/jira/browse/MESOS-9402.


> On Nov. 20, 2018, 3:47 p.m., Benjamin Bannier wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Line 4137 (original), 4135-4138 (patched)
> > <https://reviews.apache.org/r/69357/diff/2/?file=2108788#file2108788line4137>
> >
> >     Nit: overindented, see change below.

Dropping this and created https://issues.apache.org/jira/browse/MESOS-9402.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69357/#review210719
-----------------------------------------------------------


On Nov. 19, 2018, 9:09 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69357/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2018, 9:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Greg Mann, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9275
>     https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new `targetProfile` parameter to the `CREATE_DISK`
> test helper, and add profiles to all storage pools in tests.
> 
> Tests relying on preprovisioned volumes are fixed in subsequent patches.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp fdd9f871f75617fc26a28679e2a1e41f506c6133 
>   src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 
>   src/tests/mesos.hpp 576f4bde88c069ee2fa0dd33912a034437338e7e 
>   src/tests/operation_reconciliation_tests.cpp 37d38b3df8c162bd1baa5ce557e54baa5c23a006

>   src/tests/resource_provider_manager_tests.cpp 5bb740edc7c3cc8698aede4f2ed57c21232fe378

>   src/tests/storage_local_resource_provider_tests.cpp 077a46585bd56181ba199dc529e09f38f4971338

> 
> 
> Diff: https://reviews.apache.org/r/69357/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Tests `ReconcileDroppedOperation` and `ConvertPreExistingVolume` are fixed later in chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message