mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69361: Implemented the new `CREATE_DISK`/`DESTROY_DISK` semantics in SLRP.
Date Tue, 20 Nov 2018 15:01:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69361/#review210717
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On Nov. 16, 2018, 1:42 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69361/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2018, 1:42 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-9275
>     https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The default mount/block volume capabilities is removed from SLRP.
> Instead, `CREATE_DISK` will convert a preprovisioned RAW disk to a
> profile disk, and `DESTROY_DISK` will always deprovision a profile disk
> as long as the CSI plugin is capable of deprovisioning volumes.
> 
> 
> Diffs
> -----
> 
>   src/csi/utils.hpp 5ce318e52bc39555ca09bf68dca6dedea988e5a4 
>   src/resource_provider/storage/provider.cpp c137fa4f13edc58d93c03a9dd32fdf9d38b38316

> 
> 
> Diff: https://reviews.apache.org/r/69361/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message