mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Review Request 69412: Fixed thread safety issue in jwt signature validation.
Date Tue, 20 Nov 2018 14:51:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69412/
-----------------------------------------------------------

Review request for mesos, Gastón Kleiman, Greg Mann, Jan Schlicht, and Till Toenshoff.


Repository: mesos


Description
-------

The old implementation of the OpenSSl utilities which computes an HMAC
256 signature makes a non thread safe call to the OpenSSL library.

This is addressed in this patch. It also includes a test which will
cause the shared buffer to be rewritten if the non thread safe code is
executed.


Diffs
-----

  3rdparty/libprocess/src/ssl/utilities.cpp 72ad07954308db3e67c75d0fc08d46095192caca 
  3rdparty/libprocess/src/tests/jwt_tests.cpp 11ada99a971e2a8c74c3a1060a25955cc0bdeac5 


Diff: https://reviews.apache.org/r/69412/diff/1/


Testing
-------

make test


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message