mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69356: Added valiadtion for `Offer.Operation.CreateDisk.target_profile`.
Date Mon, 19 Nov 2018 21:24:46 GMT


> On Nov. 16, 2018, 12:01 p.m., Benjamin Bannier wrote:
> > This patch breaks a number of tests. Could you make sure that they are updated with
this patch or earlier?
> > 
> > Please spell-check the commit message.

Fixed the typo and the order.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69356/#review210601
-----------------------------------------------------------


On Nov. 15, 2018, 11:55 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69356/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2018, 11:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
> 
> 
> Bugs: MESOS-9275
>     https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added valiadtion for `Offer.Operation.CreateDisk.target_profile`.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 5768ac8fe802f28855fbd7be135c711115532771 
>   src/tests/master_validation_tests.cpp aa7c8f70c09459be32c6c415497e95fcdc218efd 
> 
> 
> Diff: https://reviews.apache.org/r/69356/diff/1/
> 
> 
> Testing
> -------
> 
> Tests fixed later in chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message