mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 69393: Displayed 'State' field when using 'mesos task list'.
Date Mon, 19 Nov 2018 16:03:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69393/#review210660
-----------------------------------------------------------




src/python/cli_new/lib/cli/plugins/task/main.py
Lines 125 (patched)
<https://reviews.apache.org/r/69393/#comment295384>

    Let's make the default display "UNKNOWN" instead of just blank.



src/python/cli_new/lib/cli/plugins/task/main.py
Lines 127 (patched)
<https://reviews.apache.org/r/69393/#comment295386>

    We should use [-1] here instaead of pop().



src/python/cli_new/lib/cli/tests/task.py
Line 188 (original), 189 (patched)
<https://reviews.apache.org/r/69393/#comment295385>

    Should now be UNKNOWN
    
    Keep in mind though, that this is flakey, because we don't know when the task will transition
states.


- Kevin Klues


On Nov. 19, 2018, 2:11 nachm., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69393/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2018, 2:11 nachm.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-9399
>     https://issues.apache.org/jira/browse/MESOS-9399
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Displayed 'State' field when using 'mesos task list'.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/lib/cli/plugins/task/main.py 0536ccb29551400ce59713017c86eb5e858aeb5f

>   src/python/cli_new/lib/cli/tests/task.py f033b4a7663279c8a7c49ed86b3acdda45ceb107 
> 
> 
> Diff: https://reviews.apache.org/r/69393/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> (mesos-cli) ?  cli_new (MESOS-9399) ? mesos-cli-tests
> Running the Mesos CLI unit tests
> 
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
> 
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
> 
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> 
> ----------------------------------------------------------------------
> Ran 7 tests in 20.812s
> 
> OK
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message