mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 69397: Used high-level `FrameworkInfo` validation function in tests.
Date Mon, 19 Nov 2018 15:52:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69397/
-----------------------------------------------------------

Review request for mesos and Meng Zhu.


Bugs: MESOS-8470
    https://issues.apache.org/jira/browse/MESOS-8470


Repository: mesos


Description
-------

This patch replaces uses of `framework::validateRoles` with the more
high-level `framework::validate`. Since e.g., the master invokes
`validate` instead of directly invoking `validateRoles` this ensures
that our tests more closely match master behavior, and helps
preventing that we test code which is not invoked in reality.


Diffs
-----

  src/tests/master_validation_tests.cpp aa7c8f70c09459be32c6c415497e95fcdc218efd 


Diff: https://reviews.apache.org/r/69397/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message