mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 69385: Refactored createSubject and authorizeLogAccess to common/authorization.
Date Mon, 19 Nov 2018 09:36:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69385/#review210648
-----------------------------------------------------------


Fix it, then Ship it!





src/common/http.cpp
Lines 905-906 (original), 880-881 (patched)
<https://reviews.apache.org/r/69385/#comment295373>

    Looks like another candidate for "common/authorization.hpp". Mind leaving a TODO?



src/master/master.cpp
Line 1077 (original), 1077 (patched)
<https://reviews.apache.org/r/69385/#comment295374>

    Let's leave a TODO here (it will also help explaining why you do this):
    ```
      // TODO(tillt): Use lambda named captures for
      // these cached values once it is available.
    ```



src/slave/slave.cpp
Line 839 (original), 840 (patched)
<https://reviews.apache.org/r/69385/#comment295375>

    Ditto


- Alexander Rukletsov


On Nov. 18, 2018, 11:10 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69385/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2018, 11:10 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Benjamin Bannier, and
Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moves 'createSubject' out of common/http into common/authorization.
> 
> Removes duplicate 'authorizeLogAccess' out of master.cpp and slave.cpp.
> Introduces 'authorizeLogAccess' within common/authorization.
> 
> 
> Diffs
> -----
> 
>   src/common/authorization.hpp PRE-CREATION 
>   src/common/authorization.cpp PRE-CREATION 
>   src/common/http.hpp 6ca54a641d1ea1625c70518f8870516664741e9a 
>   src/common/http.cpp eeeed9703f80880850b8a1ec9ddd2b1e8f125f36 
>   src/master/http.cpp 75ab6ea422a77e25049cd6afe007507d11650a06 
>   src/master/master.hpp e77babf22126838c63cd05e483875c9beb3ac5ff 
>   src/master/master.cpp 9458ff10999d48e40a8596ec4edf1243591bc0d4 
>   src/master/quota_handler.cpp a4975fd50a2be20f3af8bbcfa81255b5dcc64fed 
>   src/slave/http.cpp 816aed1607bb7d25851052662b6ffa306c62b983 
>   src/slave/slave.hpp 0bd340176e2a8cefdfa7ef71e059441fb171aff6 
>   src/slave/slave.cpp 74f6fb9036a9ac4f587f53ec2df04eeb4c167bfb 
> 
> 
> Diff: https://reviews.apache.org/r/69385/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` and internal CI validation
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message