mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Review Request 69384: Introduced common/authorization and refactored collectAuthorizations.
Date Sun, 18 Nov 2018 22:52:58 GMT 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69384/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Benjamin Bannier.


Bugs: MESOS-9317
    https://issues.apache.org/jira/browse/MESOS-9317


Repository: mesos


Description
-------

Adds a new collection of authorization specific helper/s to reduce code
duplication and increase efficient test coverage.

Moves the newly introduced 'collectAuthorizations' helper into this new
authorization source unit.


Diffs
-----

  src/CMakeLists.txt 732368293049b7d9d6f62057344d433637ad44e8 
  src/Makefile.am c17eae4ff1d019d515f67d81821e933ecb5dc190 
  src/common/authorization.hpp PRE-CREATION 
  src/common/authorization.cpp PRE-CREATION 
  src/master/master.hpp e77babf22126838c63cd05e483875c9beb3ac5ff 
  src/master/master.cpp 9458ff10999d48e40a8596ec4edf1243591bc0d4 
  src/master/weights_handler.cpp 222ec754e216da195250d1895a728294a076ee5d 
  src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 


Diff: https://reviews.apache.org/r/69384/diff/1/


Testing
-------

make check and private ci


Thanks,

Till Toenshoff
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message