mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.
Date Sun, 18 Nov 2018 20:13:36 GMT


> On Nov. 6, 2018, 12:19 p.m., Benno Evers wrote:
> > src/tests/master_benchmarks.cpp
> > Line 640 (original), 674-677 (patched)
> > <https://reviews.apache.org/r/68131/diff/3-4/?file=2070789#file2070789line679>
> >
> >     I'm a bit confused by the intention behind the stop condition:
> >     
> >     My best guess is that you want to ensure that you have constant load during
the whole duration of the benchmark. However, in that case it seems like the requests to `/state`
should not be limited to a specific number but continue indefinitely, and `stop` should be
set to true after the required number of requests to the indicator endpoint have happened.
> >     
> >     On the other hand, if the current implementation is as intended, I think the
message should read `launching *up to* {numRequests} requests`, because there's no guarantee
that the loop with requests for the indicator endpoint will be the one finishing first. Also,
in this case I think the comments could be a bit more specific about the intention.

I've swapped `indicator` and the `state` endpoints in regard to stopping condition. I've also
adjusted the comment. Marking as read; let me know if you think something else should be done
additionally.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68131/#review210347
-----------------------------------------------------------


On Nov. 18, 2018, 8:10 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68131/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2018, 8:10 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8975
>     https://issues.apache.org/jira/browse/MESOS-8975
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_benchmarks.cpp fbfffb69930c30b038f74e0b831fc0ae41c820f0 
> 
> 
> Diff: https://reviews.apache.org/r/68131/diff/5/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/68132/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message