mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 69368: Added test reproducing crash on authorization failure.
Date Sun, 18 Nov 2018 01:23:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69368/
-----------------------------------------------------------

(Updated Nov. 18, 2018, 1:23 a.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Benjamin Bannier.


Changes
-------

Removed unused future capture.


Bugs: MESOS-9317
    https://issues.apache.org/jira/browse/MESOS-9317


Repository: mesos


Description
-------

This test reproduces the scenario as described in MESOS-9317. The test
attempts to create a persistent volume by a web request to the
authorized V1 operator endpoint. The test assures that the underlying
authorization request fails as it can in production due to failures in
the authorization backend.
Without fixing MESOS-9317, this test crashes the master process as the
code-path involved will attempt to access the contents of the awaited
future even though the future had failed.


Diffs (updated)
-----

  src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 


Diff: https://reviews.apache.org/r/69368/diff/2/

Changes: https://reviews.apache.org/r/69368/diff/1-2/


Testing
-------

`make check` before applying the fix for MESOS-9317 and after doing so.


Thanks,

Till Toenshoff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message