mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 69210: Used the MS_SILENT mount flag to elide unwanted logging.
Date Sat, 17 Nov 2018 00:49:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69210/
-----------------------------------------------------------

(Updated Nov. 17, 2018, 12:49 a.m.)


Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Jiang Yan Xu.


Bugs: MESOS-9319
    https://issues.apache.org/jira/browse/MESOS-9319


Repository: mesos


Description
-------

After moving the container root filesystem mounts to the
`filesystem/linux` isolator, these mounts are not logged into the task
sandbox by the container launcher. Since these logs are not generally
useful to tasks, and we did't previously emit them, use the `MS_SILENT`
flag to indicate that they don't need to be logged. Since the kernel
doesn't use `MS_SILENT` for anything, we can safely use it internally.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp c7d753ac2e5575a8d687600bfb9e0617fa72c990

  src/slave/containerizer/mesos/launch.cpp 882bcdf89e2b0cca3d3f62e6d017849a51ceaead 


Diff: https://reviews.apache.org/r/69210/diff/7/

Changes: https://reviews.apache.org/r/69210/diff/6-7/


Testing
-------

make check (Fedora 28)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message