mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 69373: Replaced a log consensus `CHECK()` with CHECK_GE()`.
Date Fri, 16 Nov 2018 19:27:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69373/#review210613
-----------------------------------------------------------


Ship it!




Ship It!

- Jiang Yan Xu


On Nov. 16, 2018, 11:25 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69373/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2018, 11:25 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In scale testing, this `CHECK` failed with the following message:
> 
>   F1116 17:50:04.868387 53766 consensus.cpp:771] Check failed:
>     highestNackProposal >= proposal
> 
> Emitting the values for `highestNackProposal` and `proposal` may
> help in debugging this failure.
> 
> 
> Diffs
> -----
> 
>   src/log/consensus.cpp bce7facb0fe0d89ee96951bcf144332e41eb683e 
> 
> 
> Diff: https://reviews.apache.org/r/69373/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message