mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69360: Rewrote test `ConvertPreExistingVolume` for `CREATE_DISK`.
Date Fri, 16 Nov 2018 12:02:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69360/#review210605
-----------------------------------------------------------



This test does not pass for me, could you fix that?


src/tests/storage_local_resource_provider_tests.cpp
Line 2736 (original), 2723 (patched)
<https://reviews.apache.org/r/69360/#comment295318>

    Since we assume the first offer contains the preprovisioned disks on the next line, we
should also explicitly assert this here, e.g.,
    ```
    ASSERT_EQ(1, rawDiskOffers->size());
    ```



src/tests/storage_local_resource_provider_tests.cpp
Line 2821 (original), 2761 (patched)
<https://reviews.apache.org/r/69360/#comment295319>

    Ditto (assert exactly one offer).



src/tests/storage_local_resource_provider_tests.cpp
Line 2842 (original), 2786 (patched)
<https://reviews.apache.org/r/69360/#comment295320>

    This could be `EXPECT_FALSE`.


- Benjamin Bannier


On Nov. 16, 2018, 1:02 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69360/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2018, 1:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
> 
> 
> Bugs: MESOS-9275
>     https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Due to the changes of the `CREATE_DISK` semantics, this test is
> rewritten to convert a preprovisioned volume to a profile volumes, and
> then to destroy it to return the space back to the storage pool.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp 077a46585bd56181ba199dc529e09f38f4971338

> 
> 
> Diff: https://reviews.apache.org/r/69360/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> This test passes iff the next patch is applied.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message