mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`.
Date Fri, 16 Nov 2018 12:02:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69359/#review210604
-----------------------------------------------------------



Please move these test fixes to the patches causing the failures so we can avoid introducing
broken states in the history (useful for e.g., `git-bisect`).


src/tests/storage_local_resource_provider_tests.cpp
Line 3899 (original), 3895 (patched)
<https://reviews.apache.org/r/69359/#comment295314>

    Before dereferencing `begin` we should `ASSERT_FALSE(raw.empty())`.



src/tests/storage_local_resource_provider_tests.cpp
Lines 3898 (patched)
<https://reviews.apache.org/r/69359/#comment295315>

    Let's us a `static_cast` since this is C++.



src/tests/storage_local_resource_provider_tests.cpp
Lines 3899 (patched)
<https://reviews.apache.org/r/69359/#comment295316>

    Let's check before dereferencing `begin()` that `raw - source1` is not empty.



src/tests/storage_local_resource_provider_tests.cpp
Line 3965 (original), 3972 (patched)
<https://reviews.apache.org/r/69359/#comment295317>

    nit: If we'd break the line after `EXPECT_CALL(` all args would fit on a single line.


- Benjamin Bannier


On Nov. 16, 2018, 1 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69359/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2018, 1 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-9275
>     https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously the `ReconcileDroppedOperation` test relies on converting
> preprovisioned volumes. To adapt the new semantics for `CREATE_DISK`,
> this test is rewritten to create two disks from a storage pool, with one
> operation dropped.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp 077a46585bd56181ba199dc529e09f38f4971338

> 
> 
> Diff: https://reviews.apache.org/r/69359/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message