mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69357: Added profiles to storage pools in tests for `CREATE_DISK`.
Date Fri, 16 Nov 2018 12:01:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69357/#review210603
-----------------------------------------------------------



Can you make sure that this patch does not produce any failing tests (might be triggered by
earlier patch)?


src/tests/master_tests.cpp
Lines 8870-8875 (original), 8870-8875 (patched)
<https://reviews.apache.org/r/69357/#comment295311>

    nit: fits on a single line.



src/tests/storage_local_resource_provider_tests.cpp
Lines 2974-2975 (original), 2974 (patched)
<https://reviews.apache.org/r/69357/#comment295312>

    Unrelated to this patch?



src/tests/storage_local_resource_provider_tests.cpp
Lines 3129-3130 (original), 3128 (patched)
<https://reviews.apache.org/r/69357/#comment295313>

    Ditto.


- Benjamin Bannier


On Nov. 16, 2018, 12:58 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69357/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2018, 12:58 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Greg Mann, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9275
>     https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new `targetProfile` parameter to the `CREATE_DISK`
> test helper, and add profiles to all storage pools in tests.
> 
> Tests relying on preprovisioned volumes are fixed in subsequent patches.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp fdd9f871f75617fc26a28679e2a1e41f506c6133 
>   src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 
>   src/tests/mesos.hpp 576f4bde88c069ee2fa0dd33912a034437338e7e 
>   src/tests/operation_reconciliation_tests.cpp 37d38b3df8c162bd1baa5ce557e54baa5c23a006

>   src/tests/resource_provider_manager_tests.cpp 5bb740edc7c3cc8698aede4f2ed57c21232fe378

>   src/tests/storage_local_resource_provider_tests.cpp 077a46585bd56181ba199dc529e09f38f4971338

> 
> 
> Diff: https://reviews.apache.org/r/69357/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Tests `ReconcileDroppedOperation` and `ConvertPreExistingVolume` are fixed later in chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message