mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Review Request 69357: Added profiles to storage pools in tests for `CREATE_DISK`.
Date Thu, 15 Nov 2018 23:58:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69357/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Greg Mann, and Jan Schlicht.


Bugs: MESOS-9275
    https://issues.apache.org/jira/browse/MESOS-9275


Repository: mesos


Description
-------

This patch adds a new `targetProfile` parameter to the `CREATE_DISK`
test helper, and add profiles to all storage pools in tests.

Tests relying on preprovisioned volumes are fixed in subsequent patches.


Diffs
-----

  src/tests/api_tests.cpp fdd9f871f75617fc26a28679e2a1e41f506c6133 
  src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 
  src/tests/mesos.hpp 576f4bde88c069ee2fa0dd33912a034437338e7e 
  src/tests/operation_reconciliation_tests.cpp 37d38b3df8c162bd1baa5ce557e54baa5c23a006 
  src/tests/resource_provider_manager_tests.cpp 5bb740edc7c3cc8698aede4f2ed57c21232fe378 
  src/tests/storage_local_resource_provider_tests.cpp 077a46585bd56181ba199dc529e09f38f4971338



Diff: https://reviews.apache.org/r/69357/diff/1/


Testing
-------

`make check`

Tests `ReconcileDroppedOperation` and `ConvertPreExistingVolume` are fixed later in chain.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message