mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 69338: Change agent to not report disconnected resource providers.
Date Wed, 14 Nov 2018 16:14:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69338/#review210548
-----------------------------------------------------------



PASS: Mesos patch 69338 was successfully built and tested.

Reviews applied: `['69337', '69338']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2598/mesos-review-69338

- Mesos Reviewbot Windows


On Nov. 14, 2018, 2:36 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69338/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2018, 2:36 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-9384
>     https://issues.apache.org/jira/browse/MESOS-9384
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch changes the agent to not report disconnected resource
> providers in the `UpdateSlaveMessage` it emits. We also fix how it
> generates resource provider-related updates when no resource providers
> are connected to allow the master to react properly when a resource
> provider disappears.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 74f6fb9036a9ac4f587f53ec2df04eeb4c167bfb 
>   src/tests/resource_provider_manager_tests.cpp 5bb740edc7c3cc8698aede4f2ed57c21232fe378

> 
> 
> Diff: https://reviews.apache.org/r/69338/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message