mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 69323: Removed separate automake variables for header sources.
Date Tue, 13 Nov 2018 12:20:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69323/#review210501
-----------------------------------------------------------


Ship it!




Thanks a bunch for this James - makes rather common mistakes less likely, great improvement.

- Till Toenshoff


On Nov. 13, 2018, 5:01 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69323/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2018, 5:01 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In some cases, we were using separate automake sources variables
> to list source and header files, and in other cases, we just added
> both to the same variable. Standardize on the latter form since it
> makes it easier to see where files are listed.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
> 
> 
> Diff: https://reviews.apache.org/r/69323/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 29)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message