mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69162: Added agent and resource provider IDs to operation status messages.
Date Mon, 12 Nov 2018 20:49:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69162/
-----------------------------------------------------------

(Updated Nov. 12, 2018, 9:49 p.m.)


Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, and James DeFelice.


Changes
-------

Rebased.


Bugs: MESOS-9293
    https://issues.apache.org/jira/browse/MESOS-9293


Repository: mesos


Description
-------

This patch add agent and resource provide IDs to
`UpdateOperationStatus` and `UpdateOperationStatusMessage`. With that
frameworks are able to reconcile enough information after failover to
construct operation acknowledgements.

We will add code to populate these fields in a follow-up patch.


Diffs (updated)
-----

  include/mesos/scheduler/scheduler.proto f6a780a7b75878b9e74402a28a25bb868f7ac36f 
  include/mesos/v1/scheduler/scheduler.proto fcfec5e417463103e98dd6917722b4fde41cac7c 
  src/internal/evolve.cpp aa60efed5a28ed4d847a4a27aa8e994cda82175d 
  src/messages/messages.cpp dd8f60ecdbc06d10be1152bee1ddb65feaaf8fbb 
  src/messages/messages.proto 41e6a8a2eab0ae7c2878c1d3286c5dea0eb68ed7 


Diff: https://reviews.apache.org/r/69162/diff/3/

Changes: https://reviews.apache.org/r/69162/diff/2-3/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message