mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69163: Set agent and/or resource provider ID in operation status updates.
Date Mon, 12 Nov 2018 20:49:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69163/
-----------------------------------------------------------

(Updated Nov. 12, 2018, 9:49 p.m.)


Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, and James DeFelice.


Changes
-------

Rebased; added dedicated test.


Bugs: MESOS-9293
    https://issues.apache.org/jira/browse/MESOS-9293


Repository: mesos


Description
-------

This patch sets agent and/or resource provider ID operation status
update messages. This is not always possible, e.g., some operations
might fail validation so that no corresponding IDs can be extracted.

Since operations failing validation are currently directly rejected by
the master without going through a status update manager, they are not
retried either. If a master status update manager for operations is
introduced at a later point it should be possible to forward
acknowledgements for updates to the master's update manager (no agent
ID, not resource provider ID).


Diffs (updated)
-----

  src/common/protobuf_utils.hpp 1662125ed3e47b179ee32d08c1d3af75553066ba 
  src/common/protobuf_utils.cpp a45607eed4c4bae5010bcc3f3ffeabd6d911062a 
  src/master/master.cpp 1e326ec42a7f79a0835529a4655e7ec272f1cf40 
  src/resource_provider/manager.cpp 6c81c430e9e1205d71982a7fa2bcd9aa15fc01b2 
  src/resource_provider/storage/provider.cpp c137fa4f13edc58d93c03a9dd32fdf9d38b38316 
  src/slave/slave.cpp 74f6fb9036a9ac4f587f53ec2df04eeb4c167bfb 
  src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 


Diff: https://reviews.apache.org/r/69163/diff/3/

Changes: https://reviews.apache.org/r/69163/diff/2-3/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message