mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 69273: Fixed flaky agent reconfiguration test.
Date Mon, 12 Nov 2018 14:34:33 GMT


> On Nov. 7, 2018, 9:44 p.m., Joseph Wu wrote:
> > src/tests/slave_recovery_tests.cpp
> > Line 4739 (original), 4742 (patched)
> > <https://reviews.apache.org/r/69273/diff/1/?file=2104774#file2104774line4742>
> >
> >     Now that the clock is paused, we should deterministically not get extra offers.
 You can probably remove these blocks from the test.
> >     
> >     Here and throughout the test.

Good point, but since it seems to be dependent on resolving the issue below I've added a TODO
for now to capture this.


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69273/#review210383
-----------------------------------------------------------


On Nov. 12, 2018, 2:33 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69273/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2018, 2:33 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9358
>     https://issues.apache.org/jira/browse/MESOS-9358
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed some flakyness from the test
> SlaveRecoveryTest.AgentReconfigurationWithRunningTask
> by removing the `refuse_offers` filter and by pausing
> the clock whenever possible during the test.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 
> 
> 
> Diff: https://reviews.apache.org/r/69273/diff/2/
> 
> 
> Testing
> -------
> 
> `./src/mesos-tests --gtest_filter="*ReconfigurationWithRunning*" --gtest_repeat=200`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message