mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69161: Renamed a function argument to not reuse member name.
Date Mon, 12 Nov 2018 08:57:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69161/
-----------------------------------------------------------

(Updated Nov. 12, 2018, 9:57 a.m.)


Review request for mesos and Chun-Hung Hsiao.


Changes
-------

Addressed comment from Chun.


Repository: mesos


Description
-------

While a function argument shadowing a member variable is perfectly
legal, it is still confusing. In this patch we rename the function
argument to remove one case of such shadowing.


Diffs (updated)
-----

  src/resource_provider/storage/provider.cpp 2873b1ab300cbb72951b0cca5427ebbc451ae03d 


Diff: https://reviews.apache.org/r/69161/diff/3/

Changes: https://reviews.apache.org/r/69161/diff/2-3/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message