mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69306: Fixed parallel test runner ulimit check for setups without limits.
Date Fri, 09 Nov 2018 22:23:34 GMT


> On Nov. 9, 2018, 10:11 p.m., Chun-Hung Hsiao wrote:
> > support/mesos-gtest-runner.py
> > Line 216 (original), 214-223 (patched)
> > <https://reviews.apache.org/r/69306/diff/2/?file=2106569#file2106569line217>
> >
> >     ```
> >     nproc_limit = resource.getrlimit(resource.RLIMIT_NPROC)
> >     if nproc_limit != resource.RLIM_INFINITY and nproc_limit < requirement:
> >     ```
> 
> Ilya Pronin wrote:
>     That's nice! Didn't know Python had that module.

Yeah just discovered this in order to avoid the locale thing ;)


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69306/#review210445
-----------------------------------------------------------


On Nov. 9, 2018, 9:53 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69306/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2018, 9:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Ilya Pronin.
> 
> 
> Bugs: MESOS-9382
>     https://issues.apache.org/jira/browse/MESOS-9382
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds special handling for the case where no process rlimit
> is in effect. For that we explicitly handle an output `unlimited`
> which can be present in e.g., `C` locales.
> 
> 
> Diffs
> -----
> 
>   support/mesos-gtest-runner.py 135c4887edc5bc6137575261355d763c80531145 
> 
> 
> Diff: https://reviews.apache.org/r/69306/diff/2/
> 
> 
> Testing
> -------
> 
> Manually verified handling of cases where `ulimit` would report `unlimited`.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message