mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 69302: Added optional argument to Master operator SUBSCRIBE call.
Date Fri, 09 Nov 2018 01:57:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69302/
-----------------------------------------------------------

Review request for mesos, Gastón Kleiman and Greg Mann.


Bugs: MESOS-9258
    https://issues.apache.org/jira/browse/MESOS-9258


Repository: mesos


Description
-------

This introduces a workaround for cases where clients connect to the
master API via a proxy or load balancer.  When the proxy/load-balancer
does not close connections, the master will continue to send data
through the connection; potentially causing performance degredation
on the master.

This new argument will tell the master to close the stream after some
time has elapsed.  For the client, this disruption should be minimal
because clients should generally account for random disconnections.


Diffs
-----

  include/mesos/master/master.proto 80bd7c43cbb6d7df0dbd1c162cf4dda48f0e2e30 
  include/mesos/v1/master/master.proto cd41a7e8dc98753b5d2b8f93d92114fe97463636 


Diff: https://reviews.apache.org/r/69302/diff/1/


Testing
-------

See last review in chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message