mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 69303: Implemented an optional time-to-live on subscriber connections.
Date Fri, 09 Nov 2018 01:57:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69303/
-----------------------------------------------------------

Review request for mesos, Gastón Kleiman and Greg Mann.


Bugs: MESOS-9258
    https://issues.apache.org/jira/browse/MESOS-9258


Repository: mesos


Description
-------

When a subscriber to the master's event stream passes in an optional
argument, the master will set a timer to close the streaming connection
after the specified time.  This is one workaround for managing potential
connection leakage from having subscribers that do not close connections
(or proxies not closing connections).

TODO: Due to how the disconnection is implemented, the logs will always show:
```
master.cpp:12110] Removed subscriber <UUID> from the list of active subscribers
master.cpp:12106] Unknown subscriber <UUID> disconnected
```
But otherwise works as expected.


Diffs
-----

  src/master/http.cpp 75ab6ea422a77e25049cd6afe007507d11650a06 
  src/master/master.hpp e77babf22126838c63cd05e483875c9beb3ac5ff 
  src/master/master.cpp 1e326ec42a7f79a0835529a4655e7ec272f1cf40 
  src/master/validation.cpp 5768ac8fe802f28855fbd7be135c711115532771 
  src/tests/api_tests.cpp fdd9f871f75617fc26a28679e2a1e41f506c6133 


Diff: https://reviews.apache.org/r/69303/diff/1/


Testing
-------

```
make check

src/mesos-tests --gtest_filter="*SubscribeMaxLifetime*" --gtest_repeat=-1 --gtest_break_on_failure
```


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message