mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 68016: Added libseccomp to the build.
Date Thu, 08 Nov 2018 15:23:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68016/
-----------------------------------------------------------

(Updated Nov. 8, 2018, 3:23 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Gilbert Song, Jie Yu, James Peach, and Qian
Zhang.


Bugs: MESOS-9032
    https://issues.apache.org/jira/browse/MESOS-9032


Repository: mesos


Description
-------

This library is needed to implement Seccomp syscall filtering in the
Mesos containerizer. This patch introduces `seccomp-isolator` build
flag, which is used to include or exclude sources related to Seccomp
from the build. Since Seccomp is a Linux-specific feature, the flag
is disabled by default. Enabling `seccomp-isolator` means either:

1. Compiling and linking against the bundled version of libseccomp from
   sources (default).

2. Linking against the libseccomp installed in the OS,
   if `--with-libseccomp` build flag is provided.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt fb80b39d1717948e87256272bc5989f73d4f5995 
  3rdparty/Makefile.am e625e7be1743348d02c6dbb8e0a92d1a395b0ef4 
  3rdparty/cmake/Versions.cmake 69fc594ec5ba2887b20b88ec0767a5d801411411 
  3rdparty/versions.am 99ef92087f6958d83ba415e84db5cbbb0c597573 
  cmake/CompilationConfigure.cmake 2130c9b70eae62948d469b37692ff4eea3a4baf2 
  configure.ac 1caab4d0630821a937d92f3c788a01ae3b5dc228 
  src/CMakeLists.txt 732368293049b7d9d6f62057344d433637ad44e8 
  src/Makefile.am c17eae4ff1d019d515f67d81821e933ecb5dc190 


Diff: https://reviews.apache.org/r/68016/diff/6/

Changes: https://reviews.apache.org/r/68016/diff/5-6/


Testing
-------


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message