mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 68995: Removed the child hook `UNSET_CLOEXEC`.
Date Thu, 08 Nov 2018 06:47:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68995/#review210412
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On Oct. 14, 2018, 7:14 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68995/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2018, 7:14 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Bugs: MESOS-9164
>     https://issues.apache.org/jira/browse/MESOS-9164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We do not need this child hook since any file descripters need
> to unset the close-on-exec flag can be put in the `whitelist_fds`
> parameter of the `subprocess` method.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 135bf243c7e51c88fed6c67804af7f04a2098981

>   3rdparty/libprocess/src/subprocess.cpp c0640de2dc4278b884282dfaad98c49c3b067a5b 
> 
> 
> Diff: https://reviews.apache.org/r/68995/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message