mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 69276: Fixed flakiness in `FsTest.Used`.
Date Wed, 07 Nov 2018 21:24:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69276/#review210377
-----------------------------------------------------------


Ship it!




Ship It!

- James Peach


On Nov. 7, 2018, 9:16 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69276/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2018, 9:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James Peach.
> 
> 
> Bugs: MESOS-9316
>     https://issues.apache.org/jira/browse/MESOS-9316
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Unfortunately, we cannot easily verify that the value coming from
> `fs::used()` is correct, as the filesystem may be modified at any
> point in time.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/os/filesystem_tests.cpp 29f06f3dd126007d6b3a81f31795270f0654b847

> 
> 
> Diff: https://reviews.apache.org/r/69276/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message