mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 69275: Added environment sanity check to parallel test runner.
Date Wed, 07 Nov 2018 21:15:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69275/#review210375
-----------------------------------------------------------


Fix it, then Ship it!





support/mesos-gtest-runner.py
Lines 212 (patched)
<https://reviews.apache.org/r/69275/#comment295044>

    Double space here.


- Armand Grillet


On Nov. 7, 2018, 9:30 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69275/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2018, 9:30 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a check to the parallel test runner that catches
> setups where the user is not allowed to launch many process (e.g., the
> default value for `ulimit -u` on centos7).
> 
> This can lead to test execution failures if many `mesos-tests`
> instances are run in parallel on machines with many cores (by default
> the parallel test runner would execute `nproc` shards which would fork
> potentially multiple executable launching `nproc` libprocess worker
> threads).
> 
> 
> Diffs
> -----
> 
>   support/mesos-gtest-runner.py 9cf72af246a2fabf2cb57ed42136eeaaa1495f20 
> 
> 
> Diff: https://reviews.apache.org/r/69275/diff/1/
> 
> 
> Testing
> -------
> 
> Executed `mesos-tests` in parallel with default settings.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message