mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 67022: Refreshed checkpointed SlaveInfo if `--reconfiguration_policy==any`.
Date Wed, 07 Nov 2018 14:25:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67022/#review210367
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/slave.cpp
Lines 1592 (patched)
<https://reviews.apache.org/r/67022/#comment295042>

    I just noticed, there seems to be no reason to restrict it to the `any`-case, we probably
also want to checkpoint the new state if it changed under the `additive` policy. So the condition
could just be
    
    ```
    if (requiredMasterCapabilities.agentUpdate) {
      [...]
    ```


- Benno Evers


On Sept. 13, 2018, 5:17 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67022/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2018, 5:17 p.m.)
> 
> 
> Review request for mesos, Eric Chung and Jason Lai.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refreshed checkpointed SlaveInfo if `--reconfiguration_policy==any`.
> 
> 
> Diffs
> -----
> 
>   src/slave/flags.cpp fd53d90776967ae97575140778129d6fddd726d2 
>   src/slave/slave.cpp e6c7e686f287fb4448a0074d4e99298665fc866d 
> 
> 
> Diff: https://reviews.apache.org/r/67022/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message