mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 69255: Updated PyInstaller requirement for new CLI to support Python 3.7.
Date Mon, 05 Nov 2018 22:22:27 GMT


> On Nov. 5, 2018, 9:48 p.m., Benjamin Bannier wrote:
> > This issue could have been caught would there have been just rudimentary tests.
Could you please add a test to this RR fix that? I'd imagine a test making sure that executing
the produced binary with `--help` might already be sufficient.

I disagree regarding the "would there have been just rudimentary tests". 

The issue concerns PyInstaller, not the new CLI, which depends on the operating system and
Python version installed. We have integration tests but they do not require to build the CLI,
this is why we have not caught the bug sooner.

To do what you suggest, the best way would be to add some code to our `Makefile.am` and `src/python/cli_new/CMakeLists.txt`
to check the exit status of the built binary with `--help`. I would suggest not only running
this command with `make check` but also simply `make` as this guarantees the integrity of
the binary.

Also, we need to specify the versions of Python the CLI supports. PyInstaller tends to add
compatibility after new Python releases and it is thus likely that the problem will happen
again with Python 3.8.


- Armand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69255/#review210335
-----------------------------------------------------------


On Nov. 5, 2018, 7:13 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69255/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2018, 7:13 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Kevin Klues.
> 
> 
> Bugs: MESOS-9370
>     https://issues.apache.org/jira/browse/MESOS-9370
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated PyInstaller requirement for new CLI to support Python 3.7.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/pip-requirements.txt 520dc6131cf05e8f4626a1c673be9b6a59766a8d 
> 
> 
> Diff: https://reviews.apache.org/r/69255/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python37 ../configure --enable-new-cli
> $ make check
> $ ./src/mesos
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message