mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 69206: Updated new CLI commands for new CLI to return proper exit status.
Date Fri, 02 Nov 2018 23:45:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69206/#review210305
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Klues


On Okt. 30, 2018, 12:51 vorm., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69206/
> -----------------------------------------------------------
> 
> (Updated Okt. 30, 2018, 12:51 vorm.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-9363
>     https://issues.apache.org/jira/browse/MESOS-9363
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In a later commit, this will be used by the two subcommands 'task
> attach' and 'task exec' to return their proper exit sequences.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/bin/main.py 27783caf4eab6ea18eee5a7b90b0dd368c8b4020 
>   src/python/cli_new/lib/cli/plugins/base.py c85abd6755c4b046ab4ecbda825f3a1615fb4ce5

> 
> 
> Diff: https://reviews.apache.org/r/69206/diff/2/
> 
> 
> Testing
> -------
> 
> ```
> (mesos-cli) ?  cli_new (exec-attach) ? mesos-cli-tests
> Running the Mesos CLI unit tests
> 
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
> 
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
> 
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> 
> ----------------------------------------------------------------------
> Ran 7 tests in 17.238s
> 
> OK
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message